1.1 KiB
1.1 KiB
name, description, severity-default, tools
| name | description | severity-default | tools | ||||||
|---|---|---|---|---|---|---|---|---|---|
| effect-review | Review code against Effect Patterns best practices | medium |
|
Effect Patterns Code Review
Review the changed files to ensure they follow Effect Patterns best practices according to the canonical @docs/Effect-Patterns-Rules.md.
Instructions for the agent
- Run the AST Analyzer: You MUST use
Bashto runbun run scripts/effect-analyzer/bin/check.ts <filepath>on each modified TypeScript file. Report any warnings or errors it finds. - Read the relevant parts of
@docs/Effect-Patterns-Rules.mdif you are unsure. - Focus exclusively on Effect-TS usage. Do not comment on general formatting unless it obscures Effect best practices.
- Point out any code that uses
Promise.thenortry/catchincorrectly instead ofEffect.tryPromiseorEffect.try. - Flag usage of unstructured errors (
throw new Error()) instead of typed errors (Effect.fail).
Key aspects to check manually
If there are any violations, report them and suggest the Effect-native alternative.