Initial commit
This commit is contained in:
@@ -0,0 +1,21 @@
|
||||
---
|
||||
name: effect-review
|
||||
description: Review code against Effect Patterns best practices
|
||||
severity-default: medium
|
||||
tools: [Read, Grep, glob, get_diagnostics, Bash, oracle]
|
||||
---
|
||||
|
||||
# Effect Patterns Code Review
|
||||
|
||||
Review the changed files to ensure they follow Effect Patterns best practices according to the canonical `@docs/Effect-Patterns-Rules.md`.
|
||||
|
||||
## Instructions for the agent
|
||||
1. **Run the AST Analyzer**: You MUST use `Bash` to run `bun run scripts/effect-analyzer/bin/check.ts <filepath>` on each modified TypeScript file. Report any warnings or errors it finds.
|
||||
2. Read the relevant parts of `@docs/Effect-Patterns-Rules.md` if you are unsure.
|
||||
3. Focus exclusively on Effect-TS usage. Do not comment on general formatting unless it obscures Effect best practices.
|
||||
4. Point out any code that uses `Promise.then` or `try/catch` incorrectly instead of `Effect.tryPromise` or `Effect.try`.
|
||||
5. Flag usage of unstructured errors (`throw new Error()`) instead of typed errors (`Effect.fail`).
|
||||
|
||||
## Key aspects to check manually
|
||||
|
||||
If there are any violations, report them and suggest the Effect-native alternative.
|
||||
Reference in New Issue
Block a user