edits from review skill, merged policies, moved brand constructors

test/ingestSnapshot.test.ts

@@ -3,11 +3,7 @@ import { describe, expect, it } from "vitest"
 
 import {
   type IngestUpstreamSnapshot,
-  makeAstNodeKind,
-  makeNormalizedHash,
-  makeRawHash,
   makeRunIdentity,
-  makeShapeHash,
   makeSnapshotIdentity,
   makeTaintedBundleInput,
   makeTaintedBundleLocation,
@@ -42,9 +38,9 @@ describe("ingestSnapshot workflow", () => {
     const event = await Effect.runPromise(workflow(makeCommand()))
 
     expect(event._tag).toBe("UpstreamSnapshotIngested")
-    expect(event.payload.RunManifest.RunIdentity).toBe(makeRunIdentity("run:snapshot-001"))
+    expect(event.payload.RunManifest.RunIdentity).toBe("run:snapshot-001")
     expect(event.payload.RunManifest.ManifestPath).toBe(
-      makeTrustedManifestPath("runs/run:snapshot-001/manifest.json"),
+      "runs/run:snapshot-001/manifest.json",
     )
     expect(event.payload.SegmentRecords).toHaveLength(1)
   })
@@ -71,10 +67,10 @@ describe("ingestSnapshot workflow", () => {
       expect(nextState._tag).toBe("SnapshotIngested")
       if (nextState._tag === "SnapshotIngested") {
         expect(nextState.RunManifest.CanonicalProjectionPath).toBe(
-          makeTrustedCanonicalProjectionPath("runs/run:snapshot-001/canonical.ts"),
+          "runs/run:snapshot-001/canonical.ts",
         )
         expect(nextState.SummaryPath).toBe(
-          makeTrustedSummaryPath("runs/run:snapshot-001/summary.json"),
+          "runs/run:snapshot-001/summary.json",
         )
       }
     }
@@ -115,12 +111,13 @@ describe("ingestSnapshot workflow", () => {
 
     expect(event.payload.SegmentRecords[0]).toMatchObject({
       SegmentId: "snapshot-001:root",
-      AstNodeKind: makeAstNodeKind("Program"),
+      AstNodeKind: "Program",
       Hashes: {
-        RawHash: makeRawHash("raw:snapshot-001"),
-        NormalizedHash: makeNormalizedHash("normalized:snapshot-001"),
-        ShapeHash: makeShapeHash("shape:snapshot-001"),
+        RawHash: "raw:snapshot-001",
+        NormalizedHash: "normalized:snapshot-001",
+        ShapeHash: "shape:snapshot-001",
       },
     })
+    expect(event.payload.SegmentRecords[0]?.Hashes.RawHash).toBe("raw:snapshot-001")
   })
 })